[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/14] ppc405_boards: Don't size
From: |
David Gibson |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/14] ppc405_boards: Don't size flash memory to match backing image |
Date: |
Fri, 8 Mar 2019 22:09:51 +1100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Fri, Mar 08, 2019 at 08:24:04AM +0100, Markus Armbruster wrote:
> David Gibson <address@hidden> writes:
>
> > On Thu, Mar 07, 2019 at 02:03:16PM +0100, Markus Armbruster wrote:
> >> Machine "ref405ep" maps its flash memory at address 2^32 - image size.
> >> Image size is rounded up to the next multiple of 64KiB. Useless,
> >> because pflash_cfi02_realize() fails with "failed to read the initial
> >> flash content" unless the rounding is a no-op.
> >>
> >> If the image size exceeds 0x80000 Bytes, we overlap first SRAM, then
> >> other stuff. No idea how that would play out, but useful outcomes
> >> seem unlikely.
> >>
> >> Map the flash memory at fixed address 0xFFF80000 with size 512KiB,
> >> regardless of image size, to match the physical hardware.
> >>
> >> Machine "taihu" maps its boot flash memory similarly. The code even
> >> has a comment /* XXX: should check that size is 2MB */, followed by
> >> disabled code to adjust the size to 2MiB regardless of image size.
> >>
> >> Its code to map its application flash memory looks the same, except
> >> there the XXX comment asks for 32MiB, and the code to adjust the size
> >> isn't disabled. Note that pflash_cfi02_realize() fails with "failed
> >> to read the initial flash content" for images smaller than 32MiB.
> >>
> >> Map the boot flash memory at fixed address 0xFFE00000 with size 2MiB,
> >> to match the physical hardware. Delete dead code from application
> >> flash mapping, and simplify some.
> >>
> >> Cc: David Gibson <address@hidden>
> >> Signed-off-by: Markus Armbruster <address@hidden>
> >> Acked-by: David Gibson <address@hidden>
> >> Reviewed-by: Alex Bennée <address@hidden>
> >
> > I'm assuming because this is in a series I'm not otherwise CCed on
> > that this is going in through someone else's tree. Let me know if you
> > want me take it through mine.
>
> I intend to take the complete series through my tree unless a maintainer
> objects.
No objection here.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
[Qemu-block] [PATCH v3 02/14] pflash_cfi01: Do not exit() on guest aborting "write to buffer", Markus Armbruster, 2019/03/07
[Qemu-block] [PATCH v3 08/14] r2d: Fix flash memory size, sector size, width, device ID, Markus Armbruster, 2019/03/07
[Qemu-block] [PATCH v3 05/14] hw: Use PFLASH_CFI0{1, 2} and TYPE_PFLASH_CFI0{1, 2}, Markus Armbruster, 2019/03/07
Re: [Qemu-block] [Qemu-devel] [PATCH v3 00/14] pflash: Fixes and cleanups, no-reply, 2019/03/09