[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 4/7] block/dirty-bitmaps: prohibit readonly b
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 4/7] block/dirty-bitmaps: prohibit readonly bitmaps for backups |
Date: |
Fri, 1 Mar 2019 13:38:35 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 3/1/19 1:15 PM, John Snow wrote:
> drive and blockdev backup cannot use readonly bitmaps, because the
> sync=incremental mechanism actually edits the bitmaps on success.
>
> If you really want to do this operation, use a copied bitmap.
In fact, that's what I ended up doing in my libvirt patches, always
running sync=incremental on a temporary copy.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [Qemu-block] [PATCH v3 1/7] block/dirty-bitmaps: add inconsistent bit, (continued)
[Qemu-block] [PATCH v3 2/7] block/dirty-bitmap: add inconsistent status, John Snow, 2019/03/01
[Qemu-block] [PATCH v3 4/7] block/dirty-bitmaps: prohibit readonly bitmaps for backups, John Snow, 2019/03/01
[Qemu-block] [PATCH v3 5/7] block/dirty-bitmaps: prohibit removing readonly bitmaps, John Snow, 2019/03/01
[Qemu-block] [PATCH v3 3/7] block/dirty-bitmaps: add block_dirty_bitmap_check function, John Snow, 2019/03/01
Re: [Qemu-block] [PATCH v3 3/7] block/dirty-bitmaps: add block_dirty_bitmap_check function, Vladimir Sementsov-Ogievskiy, 2019/03/06