Re: [Qemu-block] [PATCH v14 3/3] qcow2: list of bitmaps new test 242

[Andrey Shinkevich]

On 18/02/2019 19:12, Kevin Wolf wrote:
> Am 08.02.2019 um 16:06 hat Andrey Shinkevich geschrieben:
>> A new test file 242 added to the qemu-iotests set. It checks
>> the format of qcow2 specific information for the new added
>> section that lists details of bitmaps.
>>
>> Signed-off-by: Andrey Shinkevich <address@hidden>
> 
> This doesn't seem to be Python 3 compatible.
> 
> Kevin
> 

Thank you, Kevin.
Fixed. Please review the patch
0001-iotests-handle-TypeError-for-Python3-in-test-242.patch

> 
> 242                [17:09:27] [17:09:29] [failed, exit status 1] - output 
> mismatch (see 242.out.bad)
> --- /home/kwolf/source/qemu/tests/qemu-iotests/242.out  2019-02-13 
> 12:59:38.748262364 +0100
> +++ /home/kwolf/source/qemu/tests/qemu-iotests/242.out.bad      2019-02-18 
> 17:09:29.314637597 +0100
> @@ -143,24 +143,9 @@
>   {"execute": "block-dirty-bitmap-add", "arguments": {"disabled": false, 
> "granularity": 16384, "name": "bitmap-0", "node": "drive0", "persistent": 
> true}}
>   {"return": {}}
>   Write an unknown bitmap flag '0x4' into a new QCOW2 image at offset 327695
> -qemu-img: Could not open 'TEST_IMG': Bitmap 'bitmap-0' doesn't satisfy the 
> constraints
> -
> -Unset the unknown bitmap flag '0x4' in the bitmap directory entry:
> -
> -image: TEST_IMG
> -file format: IMGFMT
> -virtual size: 1.0M (1048576 bytes)
> -cluster_size: 65536
> -Format specific information:
> -    compat: 1.1
> -    lazy refcounts: false
> -    bitmaps:
> -        [0]:
> -            flags:
> -                [0]: auto
> -            name: bitmap-0
> -            granularity: 16384
> -    refcount bits: 16
> -    corrupt: false
> -
> -Test complete
> +Traceback (most recent call last):
> +  File "242", line 98, in <module>
> +    toggle_flag(flag_offset)
> +  File "242", line 70, in toggle_flag
> +    f.write(toggled)
> +TypeError: a bytes-like object is required, not 'str'
> Failures: 242
> Failed 1 of 1 tests
> 

-- 
With the best regards,
Andrey Shinkevich