Re: [Qemu-block] [PATCH v2 2/2] iotests: add LUKS payload overhead to 178 qemu-img measure test

[Stefan Hajnoczi]

On Fri, Feb 15, 2019 at 08:14:59PM +0100, Max Reitz wrote:
> On 23.01.19 11:33, Stefan Hajnoczi wrote:
> > diff --git a/tests/qemu-iotests/178 b/tests/qemu-iotests/178
> > index 3f4b4a4564..23eb017ea1 100755
> > --- a/tests/qemu-iotests/178
> > +++ b/tests/qemu-iotests/178
> > @@ -142,6 +142,14 @@ for ofmt in human json; do
> >              # The backing file doesn't need to exist :)
> >              $QEMU_IMG measure --output=$ofmt -o backing_file=x \
> >                                -f "$fmt" -O "$IMGFMT" "$TEST_IMG"
> > +
> > +            echo
> > +            echo "== $fmt input image and LUKS encryption =="
> > +            echo
> > +            $QEMU_IMG measure --output=$ofmt \
> > +                              --object secret,id=sec0,data=base \
> > +                              -o 
> > encrypt.format=luks,encrypt.key-secret=sec0 \
> > +                              -f "$fmt" -O "$IMGFMT" "$TEST_IMG"
> 
> With the change in patch 1, it would be possible to set
> encrypt.iter-time=10, for example (default for the LUKS tests).  For me,
> that decreases the test's runtime from 24 to 15 seconds.
> 
> Pretty please? :-)

Will fix in v3.

Stefan

signature.asc
Description: PGP signature