[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 5/5] block/dirty-bitmaps: unify qmp_locked and u
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 5/5] block/dirty-bitmaps: unify qmp_locked and user_locked calls |
Date: |
Tue, 12 Feb 2019 13:27:35 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/11/19 7:02 PM, John Snow wrote:
> These mean the same thing now. Unify them and rename the merged call
> bdrv_dirty_bitmap_busy to indicate semantically what we are describing,
> as well as help disambiguate from the various _locked and _unlocked
> versions of bitmap helpers that refer to mutex locks.
Yay, definitely improved naming.
> ---
> block/dirty-bitmap.c | 41 +++++++++++++++-------------------
> blockdev.c | 18 +++++++--------
> include/block/dirty-bitmap.h | 5 ++---
> migration/block-dirty-bitmap.c | 6 ++---
> nbd/server.c | 6 ++---
> 5 files changed, 35 insertions(+), 41 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/5] dirty-bitmaps: deprecate @status field, John Snow, 2019/02/11
- [Qemu-block] [PATCH 1/5] block/dirty-bitmap: add recording and busy properties, John Snow, 2019/02/11
- [Qemu-block] [PATCH 2/5] block/dirty-bitmaps: rename frozen predicate helper, John Snow, 2019/02/11
- [Qemu-block] [PATCH 5/5] block/dirty-bitmaps: unify qmp_locked and user_locked calls, John Snow, 2019/02/11
- Re: [Qemu-block] [PATCH 5/5] block/dirty-bitmaps: unify qmp_locked and user_locked calls,
Eric Blake <=
- [Qemu-block] [PATCH 4/5] block/dirty-bitmap: explicitly lock bitmaps with successors, John Snow, 2019/02/11
- [Qemu-block] [PATCH 3/5] block/dirty-bitmap: change semantics of enabled predicate, John Snow, 2019/02/11
- Re: [Qemu-block] [PATCH 0/5] dirty-bitmaps: deprecate @status field, Eric Blake, 2019/02/12
- Re: [Qemu-block] [PATCH 0/5] dirty-bitmaps: deprecate @status field, Vladimir Sementsov-Ogievskiy, 2019/02/13