Re: [Qemu-block] [PATCH 06/13] block: Handle child references in bdrv_reopen_queue()

[Kevin Wolf]

Am 12.02.2019 um 17:28 hat Kevin Wolf geschrieben:
> > -        child_key_dot = g_strdup_printf("%s.", child->name);
> > -        qdict_extract_subqdict(explicit_options, NULL, child_key_dot);
> > -        qdict_extract_subqdict(options, &new_child_options, child_key_dot);
> > -        g_free(child_key_dot);
> > +        /* Check if the options contain a child reference */
> > +        if (qdict_haskey(options, child->name)) {
> > +            const char *childref = qdict_get_try_str(options, child->name);
> > +            /*
> > +             * The current child must not be reopened if the child
> > +             * reference does not point to it.
> > +             */
> > +            if (g_strcmp0(childref, child->bs->node_name)) {
> 
> This is where we would break the inheritance relationship.

Oops, correcting myself: It's not. We may only do that in the commit
stage, of course.

Kevin