Re: [Qemu-block] [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

[Thomas Huth]

On 2019-01-14 15:50, Eric Blake wrote:
> On 1/14/19 8:31 AM, Daniel P. Berrangé wrote:
> 
>>>
>>> Can we suppress the warnings with #pragma instead ?
>>> That would avoid compiling the .o file with different
>>> C semantics.
>>
>> IIUC this is a built-in warning you can't disable, except by changing
>> the compilation mode to have gnu89 inline semantics :-(
> 
> Could we instead fix the warning by one of:
> 
> Using pragma to declare the header as a system header (used to silence
> warnings from misbehaving external headers),

How do you do that?

> and/or adding #defines around the inclusion of the header to neutralize
> the poor warnings,

You mean something like:

#define inline /* nothing */

?

... sounds quite ugly to me, too.

> but without changing the compilation mode of the
> entire project

The patch is only changing libiscsi_cflags, so it's not affecting the
entire project, but just the files that use libiscsi.

 Thomas

signature.asc
Description: OpenPGP digital signature