qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 1/1] include: Auto-generate the sizes lookup


From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v2 1/1] include: Auto-generate the sizes lookup table
Date: Tue, 8 Jan 2019 13:20:21 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

Am 03.01.2019 um 22:33 hat Leonid Bloch geschrieben:
> The lookup table for power-of-two sizes is now auto-generated during the
> build, and not hard-coded into the units.h file.
> 
> This partially reverts commit 540b8492618eb.
> 
> Signed-off-by: Leonid Bloch <address@hidden>

During a downstream review, Max found a problem with the table that we
could fix while we're touching it:

    Upstream: All >= S_2GiB are not valid ints.  (qemu assumes that
    sizeof(int) == 4, right?)  So S_2GiB should be 2147483648u and all
    above should be ...ull or better UINT64_C().

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]