Re: [Qemu-block] [PATCH v2 03/22] maint: Allow for EXAMPLES in texi2pod

[Eric Blake]

On 12/18/18 7:46 AM, Vladimir Sementsov-Ogievskiy wrote:
> 15.12.2018 16:53, Eric Blake wrote:
>> The next commit will add an EXAMPLES section to qemu-nbd.8;
>> for that to work, we need to recognize EXAMPLES in texi2pod,
>> and we need to make all man pages be regenerated since the
>> output of texi2pod can be different.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>>

>> +qemu.1: qemu-doc.texi qemu-options.texi qemu-monitor.texi \
>> +    qemu-monitor-info.texi scripts/texi2pod.pl
>> +qemu.1: qemu-option-trace.texi scripts/texi2pod.pl
> 
> I think, no needs to add scripts/texi2pod.pl to both qemu.1: lines, as they 
> should be
> merged anyway. And if you want to add line breaking anyway, it looks better 
> to use one qemu.1:
> dependency line.

Easy to fix.

> 
> On the other hand, it may be better to add MANS variable as subset of DOCS to 
> combine all man page targets,
> and than do like $(MANS): scripts/texi2pod.pl.. (and recombine DOCS, using 
> MANS ofcourse)
> Hm, and I don't see here docs/interop/qemu-ga-ref.7 and 
> docs/interop/qemu-qmp-ref.7,
> which exist in DOCS.

Oh, good point. The .txt files should also have the dependency - in
general, ALL generated documentation should depend on the generator, not
just the man pages.  I'll have to think about respinning this patch.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature