[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v12 01/31] block: Use bdrv_refresh_filename() to
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v12 01/31] block: Use bdrv_refresh_filename() to pull |
Date: |
Sat, 22 Dec 2018 16:10:48 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 17 Dec 2018 11:43:18 PM CET, Max Reitz <address@hidden> wrote:
> @@ -3327,6 +3333,7 @@ static int img_rebase(int argc, char **argv)
> qdict_put_bool(options, BDRV_OPT_FORCE_SHARE, true);
> }
>
> + bdrv_refresh_filename(bs);
> overlay_filename = bs->exact_filename[0] ? bs->exact_filename
> : bs->filename;
> out_real_path = g_malloc(PATH_MAX);
> --
> 2.19.2
I also doubt that these new hunks are necessary, but it doesn't hurt to
be consistent :)
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-block] [PATCH v12 00/31] block: Fix some filename generation issues, Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 01/31] block: Use bdrv_refresh_filename() to pull, Max Reitz, 2018/12/17
- Re: [Qemu-block] [PATCH v12 01/31] block: Use bdrv_refresh_filename() to pull,
Alberto Garcia <=
- [Qemu-block] [PATCH v12 03/31] block: Skip implicit nodes for filename info, Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 02/31] block: Use children list in bdrv_refresh_filename, Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 04/31] block: Add BDS.auto_backing_file, Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 05/31] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 06/31] iotests.py: Add filter_imgfmt(), Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 07/31] iotests.py: Add node_info(), Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 08/31] iotests: Add test for backing file overrides, Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 09/31] block: Make path_combine() return the path, Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 12/31] block: Add bdrv_make_absolute_filename(), Max Reitz, 2018/12/17
- [Qemu-block] [PATCH v12 10/31] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2018/12/17