[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 8/9] file-posix: Fix shared locks on reopen commit
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 8/9] file-posix: Fix shared locks on reopen commit |
Date: |
Mon, 19 Nov 2018 15:29:43 +0100 |
From: Max Reitz <address@hidden>
s->locked_shared_perm is the set of bits locked in the file, which is
the inverse of the permissions actually shared. So we need to pass them
as they are to raw_apply_lock_bytes() instead of inverting them again.
Reported-by: Alberto Garcia <address@hidden>
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/file-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 58c86a01ea..07bbdab953 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -959,7 +959,7 @@ static void raw_reopen_commit(BDRVReopenState *state)
/* Copy locks to the new fd before closing the old one. */
raw_apply_lock_bytes(NULL, rs->fd, s->locked_perm,
- ~s->locked_shared_perm, false, &local_err);
+ s->locked_shared_perm, false, &local_err);
if (local_err) {
/* shouldn't fail in a sane host, but report it just in case. */
error_report_err(local_err);
--
2.19.1
- [Qemu-block] [PULL 0/9] Block layer patches, Kevin Wolf, 2018/11/19
- [Qemu-block] [PULL 1/9] nvme: fix oob access issue(CVE-2018-16847), Kevin Wolf, 2018/11/19
- [Qemu-block] [PULL 3/9] vvfat: Fix memory leak, Kevin Wolf, 2018/11/19
- [Qemu-block] [PULL 2/9] fdc: fix segfault in fdctrl_stop_transfer() when DMA is disabled, Kevin Wolf, 2018/11/19
- [Qemu-block] [PULL 7/9] block: Always abort reopen after prepare succeeded, Kevin Wolf, 2018/11/19
- [Qemu-block] [PULL 4/9] qcow2: Document some maximum size constraints, Kevin Wolf, 2018/11/19
- [Qemu-block] [PULL 5/9] qcow2: Don't allow overflow during cluster allocation, Kevin Wolf, 2018/11/19
- [Qemu-block] [PULL 6/9] iotests: Add new test 220 for max compressed cluster offset, Kevin Wolf, 2018/11/19
- [Qemu-block] [PULL 8/9] file-posix: Fix shared locks on reopen commit,
Kevin Wolf <=
- [Qemu-block] [PULL 9/9] iotests: Test file-posix locking and reopen, Kevin Wolf, 2018/11/19
- Re: [Qemu-block] [PULL 0/9] Block layer patches, Peter Maydell, 2018/11/19