[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into co
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file |
Date: |
Fri, 16 Nov 2018 15:43:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 11/16/18 3:41 PM, Eric Blake wrote:
+#!/bin/bash
I know we're using bash,
+
+function nbd_server_stop()
+{
+function nbd_server_wait_for_unix_socket()
and bash supports 'function', but it is an obsolete syntactic sugar
thing that I don't recommend using. (In ksh, it actually makes a
difference in behavior whether you use 'function' or not, and using it
in 'bash' makes it harder to port code over to 'ksh' - and hence in bash
it is obsolete because here it does NOT cause the change in behavior
that ksh users expect)
Of course, I hit send too soon, before getting to my punchline:
Since we already have so many existing iotests that use 'function', it's
better to clean that up as a separate patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [Qemu-block] [PATCH 2/6 for-3.1] nbd: stop waiting for a NBD response with NBD_CMD_DISC, (continued)
[Qemu-block] [PATCH 4/6] tests: check if qemu-nbd is still alive before waiting, Daniel P . Berrangé, 2018/11/16
[Qemu-block] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file, Daniel P . Berrangé, 2018/11/16
Re: [Qemu-block] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file, Eric Blake, 2018/11/17
[Qemu-block] [PATCH 5/6] tests: add iotests helpers for dealing with TLS certificates, Daniel P . Berrangé, 2018/11/16
[Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Daniel P . Berrangé, 2018/11/16