Re: [Qemu-block] [PATCH] qemu/units: Move out QCow2 specific definitions

[Philippe Mathieu-Daudé]

Hi Kevin,

On 2/11/18 12:07, Kevin Wolf wrote:
> Am 02.11.2018 um 09:58 hat Philippe Mathieu-Daudé geschrieben:
> > This definitions are QCow2 specific, there is no need to expose them
> > in the global namespace.
> >
> > This partially reverts commit 540b8492618eb.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> If we don't want this globally, I think we also don't want it in qcow2.

I only see this definitions used by block/qcow2.h (b6a95c6d1007).

Per 540b8492618eb description "This is needed when a size has to be 
stringified" but I can't find other code requiring these definitions in 
the codebase.

> Or at least reduce it to only those constants that qcow2 actually uses.

Fine by me, I'll let Leonid opine first.

Regards,

Phil.