qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2] Introduce attributes to qemu timer subsystem


From: Paolo Bonzini
Subject: Re: [Qemu-block] [PATCH v2] Introduce attributes to qemu timer subsystem
Date: Tue, 16 Oct 2018 15:47:37 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 16/10/2018 15:03, Artem Pisarenko wrote:
> +    if (!timer_list) {
> +        timer_list = main_loop_tlg.tl[type];
> +    }
> +    timer_init_full(ts, timer_list, scale, attributes, cb, opaque);

Please move this "if" to timer_init_full, so that here you can just pass
timer_list.  timer_init_full will then take a QEMUTimerListGroup* (NULL
defaults to &main_loop_tlg, aio_timer_new passes &ctx->tlg) and a
QEMUClockType instead of a QEMUTimerList*.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]