[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] nbd/server: fix NBD_CMD_CACHE
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH] nbd/server: fix NBD_CMD_CACHE |
|
Date: |
Wed, 3 Oct 2018 09:57:30 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/3/18 9:47 AM, Vladimir Sementsov-Ogievskiy wrote:
We should not go to structured-read branch on CACHE command, fix that.
Bug intoroduced in bc37b06a5cde24 "nbd/server: introduce NBD_CMD_CACHE"
s/intoroduced/introduced/
with the whole feature and affects 3.0.0 release.
Ouch. It's because I don't have an NBD client that can issue the
command, so the server side got released without sufficient testing. Is
there some way we could enhance qemu-io as NBD client to issue such a
command?
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
CC: address@hidden
Reviewed-by: Eric Blake <address@hidden>
Will queue through my NBD tree.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org