Re: [Qemu-block] [Qemu-devel] [PATCH] dirty-bitmaps: allow merging to disabled bitmaps

[John Snow]

On 09/26/2018 10:25 PM, Eric Blake wrote:
> On 9/19/18 4:16 PM, John Snow wrote:
>>
>>
>> On 09/19/2018 05:08 PM, Eric Blake wrote:
>>> On 9/19/18 2:58 PM, John Snow wrote:
>>>> We wish to prohibit merging to read-only bitmaps and frozen bitmaps,
>>>> but "disabled" bitmaps only preclude their recording of live, new
>>>> information. It does not prohibit them from manual writes at the behest
>>>> of the user, as is the case for merge operations.
>>>>
>>>> Reported-by: Eric Blake <address@hidden>
>>>> Signed-off-by: John Snow <address@hidden>
>>>> ---
>>>>    block/dirty-bitmap.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> I can add this to my NBD queue, if desired.
>>>
>>
>> If that makes life easier for you, then please be my guest -- otherwise
>> there's no conflict in taking it through the bitmaps tree I've got.
> 
> At this point, I'm not queuing this through NBD, as I think it is better
> served by just folding this directly into your v3 permissions series (or
> does that need to go up to v4?)
> 

Ah, NACK. This is superseded by the permissions changeset.

--js

>>
>> Just let me know either way.
>>
>