[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v10 4/9] qcow2: Avoid duplication in setting the ref
|
From: |
Leonid Bloch |
|
Subject: |
[Qemu-block] [PATCH v10 4/9] qcow2: Avoid duplication in setting the refcount cache size |
|
Date: |
Fri, 21 Sep 2018 20:23:05 +0300 |
The refcount cache size does not need to be set to its minimum value in
read_cache_sizes(), as it is set to at least its minimum value in
qcow2_update_options_prepare().
Signed-off-by: Leonid Bloch <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block/qcow2.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 67cc82f0b9..7949d15fc6 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -834,10 +834,9 @@ static void read_cache_sizes(BlockDriverState *bs,
QemuOpts *opts,
(uint64_t)DEFAULT_L2_CACHE_CLUSTERS
* s->cluster_size);
}
- if (!refcount_cache_size_set) {
- *refcount_cache_size = min_refcount_cache;
- }
}
+ /* l2_cache_size and refcount_cache_size are ensured to have at least
+ * their minimum values in qcow2_update_options_prepare() */
if (*l2_cache_entry_size < (1 << MIN_CLUSTER_BITS) ||
*l2_cache_entry_size > s->cluster_size ||
--
2.17.1
- Re: [Qemu-block] [PATCH v10 1/9] qcow2: Options' documentation fixes, (continued)
[Qemu-block] [PATCH v10 3/9] qcow2: Make sizes more humanly readable, Leonid Bloch, 2018/09/21
[Qemu-block] [PATCH v10 2/9] include: Add a lookup table of sizes, Leonid Bloch, 2018/09/21
[Qemu-block] [PATCH v10 4/9] qcow2: Avoid duplication in setting the refcount cache size,
Leonid Bloch <=
[Qemu-block] [PATCH v10 5/9] qcow2: Assign the L2 cache relatively to the image size, Leonid Bloch, 2018/09/21
[Qemu-block] [PATCH v10 6/9] qcow2: Increase the default upper limit on the L2 cache size, Leonid Bloch, 2018/09/21
[Qemu-block] [PATCH v10 7/9] qcow2: Resize the cache upon image resizing, Leonid Bloch, 2018/09/21
[Qemu-block] [PATCH v10 9/9] qcow2: Explicit number replaced by a constant, Leonid Bloch, 2018/09/21
[Qemu-block] [PATCH v10 8/9] qcow2: Set the default cache-clean-interval to 10 minutes, Leonid Bloch, 2018/09/21