Re: [Qemu-block] [Qemu-devel] [PATCH v3 17/19] test-bdrv-drain: Fix outdated comments

[Eric Blake]

On 9/20/18 11:19 AM, Kevin Wolf wrote:
> Commit 89bd030533e changed the test case from using job_sleep_ns() to
> using qemu_co_sleep_ns() instead. Also, block_job_sleep_ns() became
> job_sleep_ns() in commit 5d43e86e11f.
>
> In both cases, some comments in the test case were not updated. Do that
> now.
>
> Reported-by: Max Reitz <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   tests/test-bdrv-drain.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

> +++ b/tests/test-bdrv-drain.c
> @@ -820,9 +820,9 @@ static int coroutine_fn test_job_run(Job *job, Error **errp)
>   
>       job_transition_to_ready(&s->common.job);
>       while (!s->should_complete) {
> -        /* Avoid block_job_sleep_ns() because it marks the job as !busy. We
> -         * want to emulate some actual activity (probably some I/O) here so
> -         * that drain has to wait for this acitivity to stop. */
> +        /* Avoid job_sleep_ns() because it marks the job as !busy. We want to
> +         * emulate some actual activity (probably some I/O) here so that drain
> +         * has to wait for this acitivity to stop. */

Fix the pre-existing typo while you're here: s/acitivity/activity/

With that,
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org