[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse le
|
From: |
Jeff Cody |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames |
|
Date: |
Wed, 12 Sep 2018 08:42:15 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Sep 12, 2018 at 12:38:56PM +0200, Kevin Wolf wrote:
> Am 11.09.2018 um 20:37 hat Jeff Cody geschrieben:
> > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote:
> > > Once we load the image, will the header get rewritten into a compliant
> > > format?
> >
> > Hmm - I think in some code paths, but not all. I don't think the answer is
> > 'yes' universally, alas.
>
> Can't we explicitly call BdrvChildRole.update_filename() for all parents
> when we open a legacy filename? We'd just need to add the callback to
> child_file, which would propagate it to the parents of the format layer,
> and then just opening the image with a legacy backing file link once
> would fix the problem for this image.
>
Yes, that is a good idea. I will spin a v5 with that added.
[Qemu-block] [PATCH 1/2] block/rbd: pull out qemu_rbd_convert_options, Jeff Cody, 2018/09/11