[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/9] file-posix: x-check-cache-dropped should de
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 2/9] file-posix: x-check-cache-dropped should default to false on reopen |
Date: |
Wed, 29 Aug 2018 12:27:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-26 16:09, Alberto Garcia wrote:
> The default value of x-check-cache-dropped is false. There's no reason
> to use the previous value as a default in raw_reopen_prepare() because
> bdrv_reopen_queue_child() already takes care of putting the old
> options in the BDRVReopenState.options QDict.
Well, the reason would be because one might want to retain unspecified
values as they were set before. But we decided we don't want to do that.
> If x-check-cache-dropped was previously set but is now missing from
> the reopen QDict then it should be reset to false.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block/file-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
So:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/9] Misc reopen-related patches, Alberto Garcia, 2018/08/26
- [Qemu-block] [PATCH 2/9] file-posix: x-check-cache-dropped should default to false on reopen, Alberto Garcia, 2018/08/26
- Re: [Qemu-block] [PATCH 2/9] file-posix: x-check-cache-dropped should default to false on reopen,
Max Reitz <=
- [Qemu-block] [PATCH 1/9] qemu-io: Fix writethrough check in reopen, Alberto Garcia, 2018/08/26
- [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Alberto Garcia, 2018/08/26
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Max Reitz, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Alberto Garcia, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Max Reitz, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Max Reitz, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Alberto Garcia, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Max Reitz, 2018/08/29
[Qemu-block] [PATCH 8/9] block: Allow changing 'detect-zeroes' on reopen, Alberto Garcia, 2018/08/26