[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-3.1 v10 26/31] block/nvme: Fix bdrv_refresh_
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH for-3.1 v10 26/31] block/nvme: Fix bdrv_refresh_filename() |
|
Date: |
Tue, 28 Aug 2018 15:50:59 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 09 Aug 2018 11:35:23 PM CEST, Max Reitz wrote:
> Currently, nvme's bdrv_refresh_filename() is an exact copy of null's
> implementation. However, for null, "null-co://" and "null-aio://" are
> indeed valid filenames -- for nvme, they are not, as a device address is
> still required.
>
> The correct implementation should generate a filename of the form
> "nvme://[PCI address]/[namespace]" (as the comment above
> nvme_parse_filename() describes).
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- Re: [Qemu-block] [PATCH for-3.1 v10 18/31] block/nfs: Implement bdrv_dirname(), (continued)
- [Qemu-block] [PATCH for-3.1 v10 19/31] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 20/31] iotests: Add quorum case to test 110, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 21/31] block: Add strong_runtime_opts to BlockDriver, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 23/31] block: Generically refresh runtime options, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 22/31] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 25/31] block: Do not copy exact_filename from format file, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 26/31] block/nvme: Fix bdrv_refresh_filename(), Max Reitz, 2018/08/09
- Re: [Qemu-block] [PATCH for-3.1 v10 26/31] block/nvme: Fix bdrv_refresh_filename(),
Alberto Garcia <=
- [Qemu-block] [PATCH for-3.1 v10 24/31] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 27/31] block/curl: Harmonize option defaults, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 29/31] block/null: Generate filename even with latency-ns, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 28/31] block/curl: Implement bdrv_refresh_filename(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 30/31] block: BDS options may lack the "driver" option, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenames of internal BDSs, Max Reitz, 2018/08/09
- Re: [Qemu-block] [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues, no-reply, 2018/08/16