Re: [Qemu-block] [Qemu-devel] [PATCH 2/7] jobs: canonize Error object

[Max Reitz]

On 2018-08-23 00:50, John Snow wrote:
> 
> 
> On 08/22/2018 06:59 AM, Max Reitz wrote:
>> On 2018-08-21 02:10, John Snow wrote:
>>>
>>>
>>> On 08/17/2018 03:04 PM, John Snow wrote:
>>>> +            error_setg_errno(&job->err, -job->ret, "job failed");
>>>
>>> Kevin specifically asked for me to change this, and I lost it in the
>>> shuffle. I'll send a v3 now, since there are enough nits to warrant it,
>>> and I think I want to adjust a few things to set up the "part II"
>>> portion of this changeset a little more nicely.
>>
>> But error_setg_errno() uses either strerror() or
>> g_win32_error_message(), depending on the host OS.  I prefer that over a
>> blind strerror(), to be honest.
>>
> 
> uhh, does it...?
> 
> it looks like error_setg_errno is always error_setg_errno_internal,
> which always uses strerror... am I misreading?

Ah, right, I was...  I thought the #ifdef below somehow was referring to
the same function, so it resolved to something else.  Yeah, sure,
usually the errno values comes from something we set ourselves and not
even the real OS API, so we need to always use strerror().

Sorry.

Max

signature.asc
Description: OpenPGP digital signature