[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/7] jobs: add exit shim
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 3/7] jobs: add exit shim |
Date: |
Wed, 22 Aug 2018 13:52:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-22 13:43, Max Reitz wrote:
[...]
> I'd like .main_loop_settle(). Or .main_loop_post_run(). I think it's
> OK to have names that aren't as cool and tense as possible, when in
> return they actually tell you what they're doing. (Sure,
> .main_loop_post_run() sounds really stupid, but it tells you exactly
> when the function is called and what it's for.)
Looking at the next patch, I realized that .main_loop_complete() or
.complete_in_main_loop() would work just as well. (No, I don't see any
confusion with whether you need to call job_completed(), especially
since after this series you can probably make that function static to
job.c.)
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH 2/7] jobs: canonize Error object, (continued)
- [Qemu-block] [PATCH 6/7] jobs: utilize job_exit shim, John Snow, 2018/08/17
- [Qemu-block] [PATCH 7/7] jobs: remove job_defer_to_main_loop, John Snow, 2018/08/17
- [Qemu-block] [PATCH 3/7] jobs: add exit shim, John Snow, 2018/08/17
- Re: [Qemu-block] [PATCH 3/7] jobs: add exit shim, John Snow, 2018/08/22
- Re: [Qemu-block] [PATCH 3/7] jobs: add exit shim, Max Reitz, 2018/08/25
- Re: [Qemu-block] [PATCH 3/7] jobs: add exit shim, John Snow, 2018/08/27
- Re: [Qemu-block] [PATCH 3/7] jobs: add exit shim, Max Reitz, 2018/08/29
- Re: [Qemu-block] [Qemu-devel] [PATCH 3/7] jobs: add exit shim, Eric Blake, 2018/08/22
- Re: [Qemu-block] [Qemu-devel] [PATCH 3/7] jobs: add exit shim, John Snow, 2018/08/22
[Qemu-block] [PATCH 1/7] jobs: change start callback to run callback, John Snow, 2018/08/17