|
From: | Eric Blake |
Subject: | Re: [Qemu-block] [PATCH v2 1/2] block: allow blockdev-backup from any source |
Date: | Thu, 28 Jun 2018 13:05:11 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/28/2018 01:00 PM, John Snow wrote:
In the case of image fleecing, the node we choose as the source for a blockdev-backup is going to be both a root node AND the backing node for the exported image. It does not qualify as a root image in this case. Loosen the restriction. Signed-off-by: John Snow <address@hidden> --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
In v1, you mentioned that this used to work but then regressed, pinpointing that detail in the commit message might be nice, but not essential (since we didn't test it until now). So,
Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |