[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] usb-storage: Add rerror/werror pro
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] usb-storage: Add rerror/werror properties |
|
Date: |
Tue, 26 Jun 2018 11:14:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 26/06/2018 10:53, Daniel P. Berrangé wrote:
> On Tue, Jun 26, 2018 at 10:48:10AM +0200, Paolo Bonzini wrote:
>> On 26/06/2018 10:35, Markus Armbruster wrote:
>>> We also want to deprecate usb-storage, but
>>> I guess we're still not ready for that (it's a complicated story).
>>>
>>> To deprecate -drive without also deprecating usb-storage, we need to
>>> preserve features.
>>
>> Patch looks good to me too, but indeed why can't we deprecate
>> usb-storage in favor of usb-bot + scsi-disk?
>
> Presumably the migration state of usb-storage is different from the
> migration state of usb-bot + scsi-disk, so not a case where libvirt
> could silently switch from one to the other. It would need to be an
> explicit config change by apps/users.
>From a quick test, migrating
qemu-kvm \
-drive if=none,id=usb,file=$HOME/chipsec.img,snapshot=on \
-usb -device usb-storage,drive=usb -M q35
into
qemu-kvm \
-drive if=none,id=usb,file=$HOME/chipsec.img,snapshot=on \
-usb -device usb-bot -device scsi-disk,drive=usb -M q35
seems to work. Both of them indeed use vmstate_usb_msd for
migration.
Paolo