[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] qcow2: add compress threads
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH 3/3] qcow2: add compress threads |
|
Date: |
Thu, 14 Jun 2018 15:16:52 +0200 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 08.06.2018 um 21:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Do data compression in separate threads. This significantly improve
> performance for qemu-img convert with -W (allow async writes) and -c
> (compressed) options.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Looks correct to me, but why do we introduce a separate
MAX_COMPRESS_THREADS? Can't we simply leave the maximum number of
threads to the thread poll?
I see that you chose a much smaller number here (4 vs. 64), but is there
actually a good reason for this?
Kevin