[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 04/10] qcow2/bitmap: cache loaded bitmaps
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH v2 04/10] qcow2/bitmap: cache loaded bitmaps |
Date: |
Tue, 12 Jun 2018 22:06:07 -0400 |
For bitmaps that we succeeded in loading, we can cache a reference
to that object. This will let us iterate over the more convenient
form of in-memory bitmaps for qemu-img bitmap manipulation tools.
Signed-off-by: John Snow <address@hidden>
---
block/qcow2-bitmap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 5ae9b17928..d94b6bd5cf 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -981,6 +981,7 @@ bool qcow2_load_dirty_bitmaps(BlockDriverState *bs, Error
**errp)
if (bitmap == NULL) {
goto fail;
}
+ bm->dirty_bitmap = bitmap;
if (!(bm->flags & BME_FLAG_AUTO)) {
bdrv_disable_dirty_bitmap(bitmap);
@@ -1382,6 +1383,7 @@ void
qcow2_store_persistent_dirty_bitmaps(BlockDriverState *bs, Error **errp)
bm->name = g_strdup(name);
QSIMPLEQ_INSERT_TAIL(bm_list, bm, entry);
} else {
+ assert(bitmap == bm->dirty_bitmap);
if (!(bm->flags & BME_FLAG_IN_USE)) {
error_setg(errp, "Bitmap '%s' already exists in the image",
name);
--
2.14.3
- [Qemu-block] [PATCH v2 00/10] qemu-img: add bitmap info output, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 06/10] qcow2/bitmap: load IN_USE bitmaps if disk is RO, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 07/10] qcow2/bitmap: track bitmap type, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 05/10] qcow2/bitmap: reject IN_USE bitmaps on rw reload, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 02/10] qcow2/bitmap: avoid adjusting bm->flags for RO bitmaps, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 04/10] qcow2/bitmap: cache loaded bitmaps,
John Snow <=
- [Qemu-block] [PATCH v2 01/10] qcow2/bitmap: remove redundant arguments from bitmap_list_load, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 09/10] qapi: add bitmap info, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 03/10] qcow2/bitmap: cache bm_list, John Snow, 2018/06/12