[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 02/14] vhdx: Fix vhdx_co_create() return value
|
From: |
Jeff Cody |
|
Subject: |
Re: [Qemu-block] [PATCH 02/14] vhdx: Fix vhdx_co_create() return value |
|
Date: |
Tue, 29 May 2018 10:44:46 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, May 25, 2018 at 06:33:15PM +0200, Kevin Wolf wrote:
> .bdrv_co_create() is supposed to return 0 on success, but vhdx could
> return a positive value instead. Fix this.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/vhdx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 0b1e21c750..b1ba121bb6 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -1951,7 +1951,7 @@ static int coroutine_fn
> vhdx_co_create(BlockdevCreateOptions *opts,
> goto delete_and_exit;
> }
>
> -
> + ret = 0;
> delete_and_exit:
> blk_unref(blk);
> bdrv_unref(bs);
> --
> 2.13.6
>
>
Reviewed-by: Jeff Cody <address@hidden>
- [Qemu-block] [PATCH 00/14] block: Make blockdev-create a job and stable API, Kevin Wolf, 2018/05/25
- [Qemu-block] [PATCH 01/14] vdi: Fix vdi_co_do_create() return value, Kevin Wolf, 2018/05/25
- [Qemu-block] [PATCH 02/14] vhdx: Fix vhdx_co_create() return value, Kevin Wolf, 2018/05/25
- [Qemu-block] [PATCH 03/14] job: Add error message for failing jobs, Kevin Wolf, 2018/05/25
- [Qemu-block] [PATCH 04/14] block/create: Make x-blockdev-create a job, Kevin Wolf, 2018/05/25
- [Qemu-block] [PATCH 05/14] qemu-iotests: Add VM.get_qmp_events_filtered(), Kevin Wolf, 2018/05/25