[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 02/10] raw: Check byte range uniformly
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH v5 02/10] raw: Check byte range uniformly |
|
Date: |
Fri, 25 May 2018 16:30:01 +0100 |
|
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Wed, May 23, 2018 at 11:04:28AM +0800, Fam Zheng wrote:
> We don't verify the request range against s->size in the I/O callbacks
> except for raw_co_pwritev. This is wrong (especially for
> raw_co_pwrite_zeroes and raw_co_pdiscard), so fix them.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/raw-format.c | 64
> +++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 39 insertions(+), 25 deletions(-)
The uint64_t vs int64_t inconsistency is ugly but pre-existing due to
the interfaces:
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v5 00/10] qemu-img convert with copy offloading, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 01/10] block: Introduce API for copy offloading, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 02/10] raw: Check byte range uniformly, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 03/10] raw: Implement copy offloading, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 04/10] qcow2: Implement copy offloading, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 05/10] file-posix: Implement bdrv_co_copy_range, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 06/10] iscsi: Query and save device designator when opening, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 07/10] iscsi: Create and use iscsi_co_wait_for_task, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 08/10] iscsi: Implement copy offloading, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 09/10] block-backend: Add blk_co_copy_range, Fam Zheng, 2018/05/22
- [Qemu-block] [PATCH v5 10/10] qemu-img: Convert with copy offloading, Fam Zheng, 2018/05/22