[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 1/8] blockjob: drop block_job_pause/resume_all()
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-block] [PULL 1/8] blockjob: drop block_job_pause/resume_all() |
Date: |
Sat, 12 May 2018 10:28:17 +0100 |
Commit 8119334918e86f45877cfc139192d54f2449a239 ("block: Don't
block_job_pause_all() in bdrv_drain_all()") removed the only callers of
block_job_pause/resume_all().
Pausing and resuming now happens in child_job_drained_begin/end() so
it's no longer necessary to globally pause/resume jobs.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
include/block/blockjob_int.h | 14 --------------
blockjob.c | 27 ---------------------------
2 files changed, 41 deletions(-)
diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
index 642adce68b..d5a515de9b 100644
--- a/include/block/blockjob_int.h
+++ b/include/block/blockjob_int.h
@@ -168,20 +168,6 @@ void block_job_sleep_ns(BlockJob *job, int64_t ns);
*/
void block_job_yield(BlockJob *job);
-/**
- * block_job_pause_all:
- *
- * Asynchronously pause all jobs.
- */
-void block_job_pause_all(void);
-
-/**
- * block_job_resume_all:
- *
- * Resume all block jobs. Must be paired with a preceding block_job_pause_all.
- */
-void block_job_resume_all(void);
-
/**
* block_job_early_fail:
* @bs: The block device.
diff --git a/blockjob.c b/blockjob.c
index 27f957e571..dfffad921a 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -988,19 +988,6 @@ void *block_job_create(const char *job_id, const
BlockJobDriver *driver,
return job;
}
-void block_job_pause_all(void)
-{
- BlockJob *job = NULL;
- while ((job = block_job_next(job))) {
- AioContext *aio_context = blk_get_aio_context(job->blk);
-
- aio_context_acquire(aio_context);
- block_job_ref(job);
- block_job_pause(job);
- aio_context_release(aio_context);
- }
-}
-
void block_job_early_fail(BlockJob *job)
{
assert(job->status == BLOCK_JOB_STATUS_CREATED);
@@ -1078,20 +1065,6 @@ void coroutine_fn block_job_pause_point(BlockJob *job)
}
}
-void block_job_resume_all(void)
-{
- BlockJob *job, *next;
-
- QLIST_FOREACH_SAFE(job, &block_jobs, job_list, next) {
- AioContext *aio_context = blk_get_aio_context(job->blk);
-
- aio_context_acquire(aio_context);
- block_job_resume(job);
- block_job_unref(job);
- aio_context_release(aio_context);
- }
-}
-
/*
* Conditionally enter a block_job pending a call to fn() while
* under the block_job_lock critical section.
--
2.17.0
- [Qemu-block] [PULL 0/8] Block patches, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 2/8] checkpatch: add a --strict check for utf-8 in commit logs, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 1/8] blockjob: drop block_job_pause/resume_all(),
Stefan Hajnoczi <=
- [Qemu-block] [PULL 4/8] checkpatch: ignore email headers better, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 3/8] checkpatch: check utf-8 content from a commit log when it's missing from charset, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 6/8] checkpatch: reduce MAINTAINERS update message frequency, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 5/8] checkpatch: emit a warning on file add/move/delete, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 7/8] block/file-posix: implement bdrv_co_invalidate_cache() on Linux, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 8/8] block/file-posix: add x-check-page-cache=on|off option, Stefan Hajnoczi, 2018/05/12
- Re: [Qemu-block] [Qemu-devel] [PULL 0/8] Block patches, no-reply, 2018/05/12
- Re: [Qemu-block] [PULL 0/8] Block patches, Peter Maydell, 2018/05/14