[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 37/39] iotests: Test valid values of l2-cache
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v4 37/39] iotests: Test valid values of l2-cache-entry-size |
Date: |
Tue, 13 Feb 2018 13:32:17 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 05.02.2018 um 15:33 hat Alberto Garcia geschrieben:
> The l2-cache-entry-size setting can only contain values that are
> powers of two between 512 and the cluster size.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/103 | 17 +++++++++++++++++
> tests/qemu-iotests/103.out | 3 +++
> 2 files changed, 20 insertions(+)
>
> diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103
> index d0cfab8844..7a2ca22803 100755
> --- a/tests/qemu-iotests/103
> +++ b/tests/qemu-iotests/103
> @@ -66,6 +66,14 @@ $QEMU_IO -c "open -o cache-size=1M,refcount-cache-size=2M
> $TEST_IMG" 2>&1 \
> $QEMU_IO -c "open -o cache-size=0,l2-cache-size=0,refcount-cache-size=0
> $TEST_IMG" \
> 2>&1 | _filter_testdir | _filter_imgfmt
>
> +# Invalid cache entry sizes
> +$QEMU_IO -c "open -o l2-cache-entry-size=256 $TEST_IMG" \
> + 2>&1 | _filter_testdir | _filter_imgfmt
> +$QEMU_IO -c "open -o l2-cache-entry-size=300 $TEST_IMG" \
> + 2>&1 | _filter_testdir | _filter_imgfmt
If you wanted to test non-power-of-two values here, it would be better
to use a value that isn't < 512 at the same time.
> +$QEMU_IO -c "open -o l2-cache-entry-size=128k $TEST_IMG" \
> + 2>&1 | _filter_testdir | _filter_imgfmt
Kevin
- [Qemu-block] [PATCH v4 13/39] qcow2: Add l2_slice_size field to BDRVQcow2State, (continued)
- [Qemu-block] [PATCH v4 13/39] qcow2: Add l2_slice_size field to BDRVQcow2State, Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 11/39] qcow2: Remove BDS parameter from qcow2_cache_is_table_offset(), Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 12/39] qcow2: Add offset_to_l1_index(), Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 03/39] qcow2: Remove BDS parameter from qcow2_cache_get_table_addr(), Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 01/39] qcow2: Fix documentation of get_cluster_table(), Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 09/39] qcow2: Remove BDS parameter from qcow2_cache_clean_unused(), Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 34/39] qcow2: Rename l2_table in count_contiguous_clusters_unallocated(), Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 02/39] qcow2: Add table size field to Qcow2Cache, Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 37/39] iotests: Test valid values of l2-cache-entry-size, Alberto Garcia, 2018/02/05
- Re: [Qemu-block] [PATCH v4 37/39] iotests: Test valid values of l2-cache-entry-size,
Kevin Wolf <=
- [Qemu-block] [PATCH v4 33/39] qcow2: Rename l2_table in count_contiguous_clusters(), Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 38/39] iotests: Test downgrading an image using a small L2 slice size, Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 36/39] qcow2: Allow configuring the L2 slice size, Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 32/39] qcow2: Rename l2_table in qcow2_alloc_compressed_cluster_offset(), Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 30/39] qcow2: Update expand_zero_clusters_in_l1() to support L2 slices, Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 31/39] qcow2: Update qcow2_truncate() to support L2 slices, Alberto Garcia, 2018/02/05
- [Qemu-block] [PATCH v4 39/39] iotests: Add l2-cache-entry-size to iotest 137, Alberto Garcia, 2018/02/05