Re: [Qemu-block] [PULL 6/8] iotest 205: new test for qmp nbd-server-remove

[Vladimir Sementsov-Ogievskiy]

05.02.2018 12:24, Kevin Wolf wrote:
> Am 26.01.2018 um 17:04 hat Eric Blake geschrieben:
> > From: Vladimir Sementsov-Ogievskiy <address@hidden>
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > Message-Id: <address@hidden>
> > [eblake: adjust to next available test number]
> > Signed-off-by: Eric Blake <address@hidden>
> > ---
> >   tests/qemu-iotests/205     | 156 +++++++++++++++++++++++++++++++++++++++++++++
> >   tests/qemu-iotests/205.out |   5 ++
> >   tests/qemu-iotests/group   |   1 +
> >   3 files changed, 162 insertions(+)
> >   create mode 100644 tests/qemu-iotests/205
> >   create mode 100644 tests/qemu-iotests/205.out
> This test case fails for luks. Maybe it's easy enough to enable luks, or
> maybe we have to disable it. Not sure how other Python test cases handle
> this. Can you have a look, please?
>
> Kevin

Hmm.

check -luks 205
...
+qemu-img: /work/src/qemu/master/tests/qemu-iotests/scratch/disk: 
Parameter 'key-secret' is required for cipher


I've looked through (grep-ped through) tests, and found only one python 
test with key-secret: 149. And it has own qemu_img_create() function.

On the other hand, all python tests, which have "qemu_img('create'" 
pattern, do not support luks. So, it should be easier to disable luks here.
I'll send a patch.

Also, why check-block do not check luks?

--
Best regards,
Vladimir