[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 1/9] mirror: inherit supported write/zero fla
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v7 1/9] mirror: inherit supported write/zero flags |
Date: |
Mon, 29 Jan 2018 20:21:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2018-01-18 18:48, Anton Nefedov wrote:
> Signed-off-by: Anton Nefedov <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> ---
> block/mirror.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index c9badc1..d18ec65 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -1064,6 +1064,11 @@ static void
> bdrv_mirror_top_refresh_filename(BlockDriverState *bs, QDict *opts)
> bdrv_refresh_filename(bs->backing->bs);
> pstrcpy(bs->exact_filename, sizeof(bs->exact_filename),
> bs->backing->bs->filename);
> + bs->supported_write_flags = BDRV_REQ_FUA &
> + bs->backing->bs->supported_write_flags;
> + bs->supported_zero_flags =
> + (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) &
> + bs->backing->bs->supported_zero_flags;
> }
>
> static void bdrv_mirror_top_close(BlockDriverState *bs)
Fundamentally OK, but why is this in *_refresh_filename()?
Max
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH v7 5/9] file-posix: support BDRV_REQ_ALLOCATE, Anton Nefedov, 2018/01/18
[Qemu-block] [PATCH v7 7/9] qcow2: move is_zero() up, Anton Nefedov, 2018/01/18
[Qemu-block] [PATCH v7 3/9] block: introduce BDRV_REQ_ALLOCATE flag, Anton Nefedov, 2018/01/18