[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 0/6] nbd export qmp interface
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 0/6] nbd export qmp interface |
Date: |
Thu, 18 Jan 2018 16:45:17 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote:
> v2:
> 01: tweak comment
> add Eric's r-b
> 02: new patch
> 03: rewritten, to move form 'bool force' flag to 'enum mode' parameter
> 04: add Eric's r-b
> 05: improve commit message
> tweak comment
> 06: rebase on 03 changes
> make PEP8 happy
> some other tweaks
> I've left nbd_port variable hard-set to 10900. I think all such things
> should be fixed together, and it is simple to change in future
> nbd_port = '10900'
> to
> nbd_port = iotests.get_free_port()
> if needed.
>
> [Unfortunately, qmp query-nbd-server is not finished yet, coming soon,
> but may be after my vocation on the next week]
Enjoy your time off. I think the series is nearly ready to go; I had
some tweaks that I suggested, and will probably replace your 2/6 with my
counterproposal, but I don't mind doing that cleanup if you don't have
time to respin. I'll give it a few more days in case anyone else has
comments, then add it to my NBD queue.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add, (continued)
- [Qemu-block] [PATCH v2 5/6] iotests: implement QemuIoInteractive class, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 1/6] qapi: add name parameter to nbd-server-add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 4/6] iotest 147: add cases to test new @name parameter of nbd-server-add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove, Vladimir Sementsov-Ogievskiy, 2018/01/18
- Re: [Qemu-block] [PATCH v2 0/6] nbd export qmp interface,
Eric Blake <=