[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead with
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U |
Date: |
Tue, 9 Jan 2018 14:24:25 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, 01/08 18:57, Kevin Wolf wrote:
> I'm not sure if going back to the old behaviour for a while now would be
> helpful, you'd just end up with an even more confusing set of qemu
> versions, for example:
>
> <= 2.9 - works without a warning
> 2.10 and 2.11 - errors out
> 2.12 - prints a warning, but works
> >= 2.13 - errors out again
What I had in mind is settle on warning for good. QEMU (including qemu-img) is a
low level tool that can be used in many ways that it isn't supposed to, this one
is not more harmful than others (e.g. "qemu-img snapshot ..." on iscsi:// qcow2
image) we allow siliently.
I know this is debatable but I think the #1 purpose of image locking is to
prevent data corruption; #2 IMO is to reduce confusion and misinformation.
While inconsistent output of "qemu-img info" is misinformation, it not working
as before is actually confusion. Though the current behavior is indeed ideal,
the proposed patch is a bit more pragmatical.
Fam
- [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Fam Zheng, 2018/01/05
- [Qemu-block] [PATCH 2/2] qemu-img: info: try -U automatically, Fam Zheng, 2018/01/05
- [Qemu-block] [PATCH 1/2] qemu-img: Move img_open error reporting to callers, Fam Zheng, 2018/01/05
- Re: [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Kevin Wolf, 2018/01/08
- Re: [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Nir Soffer, 2018/01/08
- Re: [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Kevin Wolf, 2018/01/08
- Re: [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U,
Fam Zheng <=
- Re: [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Kevin Wolf, 2018/01/09
- Re: [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Ala Hino, 2018/01/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Eric Blake, 2018/01/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Ala Hino, 2018/01/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Daniel P. Berrange, 2018/01/10
Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Daniel P. Berrange, 2018/01/10
Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U, Kashyap Chamarthy, 2018/01/10