[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 5/6] block: Don't wait for requests in bdrv_drain
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH v2 5/6] block: Don't wait for requests in bdrv_drain*_end() |
Date: |
Wed, 6 Dec 2017 11:53:08 +0100 |
The device is drained, so there is no point in waiting for requests at
the end of the drained section. Remove the bdrv_drain_recurse() calls
there.
The bdrv_drain_recurse() calls were introduced in commit 481cad48e5e
in order to call the the .bdrv_co_drain_end() driver callback. This is
now done by a separate bdrv_drain_invoke() call.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/io.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index 390d463c71..5fdb92a15e 100644
--- a/block/io.c
+++ b/block/io.c
@@ -299,7 +299,6 @@ void bdrv_drained_end(BlockDriverState *bs)
bdrv_parent_drained_end(bs);
bdrv_drain_invoke(bs, false);
- bdrv_drain_recurse(bs);
aio_enable_external(bdrv_get_aio_context(bs));
}
@@ -400,7 +399,6 @@ void bdrv_drain_all_end(void)
aio_enable_external(aio_context);
bdrv_parent_drained_end(bs);
bdrv_drain_invoke(bs, false);
- bdrv_drain_recurse(bs);
aio_context_release(aio_context);
}
--
2.13.6
- [Qemu-block] [PATCH v2 0/6] block: Fix BlockDriver callbacks in bdrv_drain_all_begin(), Kevin Wolf, 2017/12/06
- [Qemu-block] [PATCH v2 1/6] block: Make bdrv_drain_invoke() recursive, Kevin Wolf, 2017/12/06
- [Qemu-block] [PATCH v2 2/6] block: Call .drain_begin only once in bdrv_drain_all_begin(), Kevin Wolf, 2017/12/06
- [Qemu-block] [PATCH v2 3/6] test-bdrv-drain: Test BlockDriver callbacks for drain, Kevin Wolf, 2017/12/06
- [Qemu-block] [PATCH v2 4/6] block: bdrv_drain_recurse(): Remove unused begin parameter, Kevin Wolf, 2017/12/06
- [Qemu-block] [PATCH v2 5/6] block: Don't wait for requests in bdrv_drain*_end(),
Kevin Wolf <=
- [Qemu-block] [PATCH v2 6/6] block: Unify order in drain functions, Kevin Wolf, 2017/12/06
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] block: Fix BlockDriver callbacks in bdrv_drain_all_begin(), Stefan Hajnoczi, 2017/12/08
- Re: [Qemu-block] [PATCH v2 0/6] block: Fix BlockDriver callbacks in bdrv_drain_all_begin(), Kevin Wolf, 2017/12/08