[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/3] block: add bdrv_co_drain_end callback
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH 1/3] block: add bdrv_co_drain_end callback |
|
Date: |
Wed, 20 Sep 2017 15:26:32 +0100 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Sep 20, 2017 at 01:23:09PM +0300, Manos Pitsidianakis wrote:
> @@ -188,7 +194,7 @@ static bool bdrv_drain_recurse(BlockDriverState *bs)
> waited = BDRV_POLL_WHILE(bs, atomic_read(&bs->in_flight) > 0);
>
> /* Ensure any pending metadata writes are submitted to bs->file. */
> - bdrv_drain_invoke(bs);
> + bdrv_drain_invoke(bs, begin);
Do you need to move bdrv_drain_invoke(bs, begin) before
BDRV_POLL_WHILE(bs, atomic_read(&bs->in_flight) > 0)?
This will ensure that throttling is disabled and the TGM restarted
before we wait for requests to complete.
Stefan