|
From: | John Snow |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH v7 06/20] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes |
Date: | Wed, 13 Sep 2017 19:39:00 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/12/2017 04:31 PM, Eric Blake wrote: > We're already reporting bytes for bdrv_dirty_bitmap_granularity(); > mixing bytes and sectors in our return values is a recipe for > confusion. A later cleanup will convert dirty bitmap internals > to be entirely byte-based, but in the meantime, we should report > the bitmap size in bytes. > > The only external caller in qcow2-bitmap.c is temporarily more verbose > (because it is still using sector-based math), but will later be > switched to track progress by bytes instead of sectors. > > Signed-off-by: Eric Blake <address@hidden> > Reviewed-by: John Snow <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |