[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 08/10] qemu-iotests: fix uninitiali
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 08/10] qemu-iotests: fix uninitialized variable |
Date: |
Tue, 12 Sep 2017 16:30:21 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> The variable is used in "common" but defined only after the file
> is sourced.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> tests/qemu-iotests/check | 2 --
> tests/qemu-iotests/common | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
> +tmp="${TEST_DIR}"/$$
Pre-existing to your code motion, but would we be any safer if $tmp also
included a use of $RANDOM? (The $$ already protects us from collisions
with a parallel run, but it is easy to guess, so if $tmp is used to
create any file that an attacker can access, running the testsuite may
expose a machine to a symlink or other attack - but we probably have
lots of those things to audit for before we can recommend running the
testsuite in an untrusted environment).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH 04/10] qemu-iotests: cleanup and fix search for programs, (continued)
[Qemu-block] [PATCH 06/10] qemu-iotests: do not include common.rc in "check", Paolo Bonzini, 2017/09/12
[Qemu-block] [PATCH 05/10] qemu-iotests: limit non-_PROG-suffixed variables to common.rc, Paolo Bonzini, 2017/09/12
[Qemu-block] [PATCH 07/10] qemu-iotests: disintegrate more parts of common.config, Paolo Bonzini, 2017/09/12
[Qemu-block] [PATCH 08/10] qemu-iotests: fix uninitialized variable, Paolo Bonzini, 2017/09/12
- Re: [Qemu-block] [Qemu-devel] [PATCH 08/10] qemu-iotests: fix uninitialized variable,
Eric Blake <=
[Qemu-block] [PATCH 10/10] qemu-iotests: merge "check" and "common", Paolo Bonzini, 2017/09/12
[Qemu-block] [PATCH 09/10] qemu-iotests: get rid of $iam, Paolo Bonzini, 2017/09/12
Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests, Thomas Huth, 2017/09/13