[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QM
From: |
Kashyap Chamarthy |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python |
Date: |
Mon, 4 Sep 2017 17:05:54 +0200 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Mon, Sep 04, 2017 at 03:48:12PM +0100, Daniel P. Berrange wrote:
> On Mon, Sep 04, 2017 at 01:16:16PM +0200, Kashyap Chamarthy wrote:
> > The test 192 ("Test NBD export with '-incoming' (non-shared
> > storage migration use case from libvirt")) is currently using HMP.
> > Replace the HMP usage with QMP, as the upstream preference seems to be:
> > "Use QMP where possible, unless you're explicitly testing something
> > related to HMP".
> >
> > While at it, convert the test from Bash to Python.
>
> FYI This looks like it'll clash with the patch I sent to fix this
> test case with LUKS
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg00041.html
Oh, thanks for the pointer. Then, I think I should wait until yours is
merged, and then rework my changes on top of it.
--
/kashyap