[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v6 28/29] libqtest: Remove qtest_st
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v6 28/29] libqtest: Remove qtest_start() and qtest_end() shortcuts |
|
Date: |
Fri, 1 Sep 2017 19:16:47 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 09/01/2017 02:03 PM, Eric Blake wrote:
> Remove the trivial wrappers qtest_start() and qtest_end(), to make
> it obvious in the rest of the testsuite where we are still relying on
> global_qtest. Doing this makes it easier to see what remaining
> cleanups will be needed if we don't want an implicit dependency
> on global state. Many tests can also take advantage of qtest_init()
> doing formatting of args, avoiding a temporary local variable.
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: John Snow <address@hidden>
diffstat looks like a win overall, unless it's just a local minima ;)