Re: [Qemu-block] [Qemu-devel] [PATCH 10/12] qemu-iotests: get rid of $iam

[Philippe Mathieu-Daudé]

On 08/09/2017 06:55 PM, Paolo Bonzini wrote:
> The variable is almost unused, and one of the two uses is actually
> uninitialized.
>
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   tests/qemu-iotests/check     | 5 +----
>   tests/qemu-iotests/common.rc | 2 +-
>   2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index e5d1ae3d92..dc60e17e6a 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -30,12 +30,9 @@ interrupt=true
>   # by default don't output timestamps
>   timestamp=${TIMESTAMP:=false}
>   
> -# generic initialization
> -iam=check
> -
>   _init_error()
>   {
> -    echo "$iam: $1" >&2
> +    echo "check: $1" >&2
>       exit 1
>   }
>   
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 7046a83974..d0aa22543e 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -43,7 +43,7 @@ poke_file()
>   
>   if ! . ./common.config
>       then
> -    echo "$iam: failed to source common.config"
> +    echo "$0: failed to source common.config"
>       exit 1
>   fi
>