Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS

[John Snow]

On 08/08/2017 02:34 PM, Paolo Bonzini wrote:
> 
> 
> ----- Original Message -----
>> From: "John Snow" <address@hidden>
>> To: address@hidden
>> Cc: address@hidden, address@hidden, address@hidden, address@hidden, 
>> address@hidden,
>> address@hidden, "John Snow" <address@hidden>
>> Sent: Tuesday, August 8, 2017 7:57:10 PM
>> Subject: [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS
>>
>> From: Kevin Wolf <address@hidden>
>>
>> This allows us to detect errors in cache flushing (ENOMEDIUM)
>> without choking on a null dereference because we assume that
>> blk_bs(bb) is always defined.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> Signed-off-by: John Snow <address@hidden>
> 
> This is not enough, as discussed in the thread.
> 
> Paolo
> 

Sure, I amended Kevin's later fix and rolled it into one patch and split
the tests out. The cover letter states that this is busted, but I wanted
it on the list instead of buried in a now-unrelated thread.

So now it's here as a patch, can we keep discussion here instead of on
the other thread?

--John