[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block: document semanatics of bdrv_co_preadv|pw
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH] block: document semanatics of bdrv_co_preadv|pwritev |
|
Date: |
Fri, 4 Aug 2017 10:41:54 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/04/2017 09:06 AM, Daniel P. Berrange wrote:
> On Fri, Aug 04, 2017 at 04:02:10PM +0200, Kevin Wolf wrote:
>> Am 04.08.2017 um 12:50 hat Daniel P. Berrange geschrieben:
>>> Signed-off-by: Daniel P. Berrange <address@hidden>
>>> ---
>> Really? We are asserting that they match in bdrv_aligned_preadv():
>>
>> assert(!qiov || bytes == qiov->size);
>
> Hmm, why do we pass @bytes at all then ? If they're always the same,
> how about deleting it and just letting everyone read qiov->size
> directly.
Read the assertion again: qiov can be NULL (generally, when writing
zeroes). So we can't rely on qiov->size in that scenario.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature