Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 07/18/2017 02:43 PM, Markus Armbruster wrote:
>> @@ -536,10 +537,11 @@ can only express a choice between types represented 
>> differently in
>>  JSON.  If a branch is typed as the 'bool' built-in, the alternate
>>  accepts true and false; if it is typed as any of the various numeric
>>  built-ins, it accepts a JSON number; if it is typed as a 'str'
>> -built-in or named enum type, it accepts a JSON string; and if it is
>> -typed as a complex type (struct or union), it accepts a JSON object.
>> -Two different complex types, for instance, aren't permitted, because
>> -both are represented as a JSON object.
>> +built-in or named enum type, it accepts a JSON string; if it is typed
>> +as the 'null' built-in, it accepts JSON null, and if it is typed as a
>> +complex type (struct or union), it accepts a JSON object.  Two
>
> Grammar tweak: s/null,/null;/
>
> In a list of phrases that all have commas, it's typical to graduate the
> list separator to semicolon, so that it becomes easier to see the flow
> of 'a,b; a,b; and a,b'

Fixed, thanks!