qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a f


From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
Date: Tue, 18 Jul 2017 15:08:04 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/18/2017 02:43 PM, Markus Armbruster wrote:
> @@ -536,10 +537,11 @@ can only express a choice between types represented 
> differently in
>  JSON.  If a branch is typed as the 'bool' built-in, the alternate
>  accepts true and false; if it is typed as any of the various numeric
>  built-ins, it accepts a JSON number; if it is typed as a 'str'
> -built-in or named enum type, it accepts a JSON string; and if it is
> -typed as a complex type (struct or union), it accepts a JSON object.
> -Two different complex types, for instance, aren't permitted, because
> -both are represented as a JSON object.
> +built-in or named enum type, it accepts a JSON string; if it is typed
> +as the 'null' built-in, it accepts JSON null, and if it is typed as a
> +complex type (struct or union), it accepts a JSON object.  Two

Grammar tweak: s/null,/null;/

In a list of phrases that all have commas, it's typical to graduate the
list separator to semicolon, so that it becomes easier to see the flow
of 'a,b; a,b; and a,b'


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]