[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 10/23] block: Switch bdrv_common_block_status_abo
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH v3 10/23] block: Switch bdrv_common_block_status_above() to byte-based |
Date: |
Thu, 13 Jul 2017 10:46:58 -0500 |
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change).
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
v3: rebase to allocation/mapping sense change, simple enough to keep R-b
v2: new patch
---
block/io.c | 41 +++++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/block/io.c b/block/io.c
index 68d383d..b639e10 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1938,19 +1938,18 @@ static void coroutine_fn
bdrv_get_block_status_above_co_entry(void *opaque)
static int64_t bdrv_common_block_status_above(BlockDriverState *bs,
BlockDriverState *base,
bool mapping,
- int64_t sector_num,
- int nb_sectors, int *pnum,
+ int64_t offset,
+ int64_t bytes, int64_t *pnum,
BlockDriverState **file)
{
Coroutine *co;
- int64_t n;
BdrvCoBlockStatusData data = {
.bs = bs,
.base = base,
.file = file,
- .offset = sector_num * BDRV_SECTOR_SIZE,
- .bytes = nb_sectors * BDRV_SECTOR_SIZE,
- .pnum = &n,
+ .offset = offset,
+ .bytes = bytes,
+ .pnum = pnum,
.mapping = mapping,
.done = false,
};
@@ -1964,8 +1963,6 @@ static int64_t
bdrv_common_block_status_above(BlockDriverState *bs,
bdrv_coroutine_enter(bs, co);
BDRV_POLL_WHILE(bs, !data.done);
}
- assert(data.ret < 0 || QEMU_IS_ALIGNED(n, BDRV_SECTOR_SIZE));
- *pnum = n >> BDRV_SECTOR_BITS;
return data.ret;
}
@@ -1975,8 +1972,19 @@ int64_t bdrv_get_block_status_above(BlockDriverState *bs,
int nb_sectors, int *pnum,
BlockDriverState **file)
{
- return bdrv_common_block_status_above(bs, base, true, sector_num,
- nb_sectors, pnum, file);
+ int64_t ret;
+ int64_t n;
+
+ ret = bdrv_common_block_status_above(bs, base, true,
+ sector_num * BDRV_SECTOR_SIZE,
+ nb_sectors * BDRV_SECTOR_SIZE,
+ &n, file);
+ if (ret < 0) {
+ return ret;
+ }
+ assert(QEMU_IS_ALIGNED(n, BDRV_SECTOR_SIZE));
+ *pnum = n >> BDRV_SECTOR_BITS;
+ return ret;
}
int64_t bdrv_block_status(BlockDriverState *bs,
@@ -2001,20 +2009,13 @@ int coroutine_fn bdrv_is_allocated(BlockDriverState
*bs, int64_t offset,
int64_t bytes, int64_t *pnum)
{
int64_t ret;
- int psectors;
+ int64_t dummy;
- assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE));
- assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE) && bytes < INT_MAX);
- ret = bdrv_common_block_status_above(bs, backing_bs(bs), false,
- offset >> BDRV_SECTOR_BITS,
- bytes >> BDRV_SECTOR_BITS, &psectors,
- NULL);
+ ret = bdrv_common_block_status_above(bs, backing_bs(bs), false, offset,
+ bytes, pnum ? pnum : &dummy, NULL);
if (ret < 0) {
return ret;
}
- if (pnum) {
- *pnum = psectors * BDRV_SECTOR_SIZE;
- }
return !!(ret & BDRV_BLOCK_ALLOCATED);
}
--
2.9.4
- [Qemu-block] [PATCH v3 00/23] make bdrv_get_block_status byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 02/23] block: Add flag to avoid wasted work in bdrv_is_allocated(), Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 01/23] block: Allow NULL file for bdrv_get_block_status(), Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 03/23] block: Make bdrv_round_to_clusters() signature more useful, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 05/23] block: Switch bdrv_make_zero() to byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 06/23] qemu-img: Switch get_block_status() to byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 04/23] qcow2: Switch is_zero_sectors() to byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 07/23] block: Convert bdrv_get_block_status() to bytes, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 08/23] block: Switch bdrv_co_get_block_status() to byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 09/23] block: Switch BdrvCoGetBlockStatusData to byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 10/23] block: Switch bdrv_common_block_status_above() to byte-based,
Eric Blake <=
- [Qemu-block] [PATCH v3 11/23] block: Switch bdrv_co_get_block_status_above() to byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 12/23] block: Convert bdrv_get_block_status_above() to bytes, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 13/23] qemu-img: Simplify logic in img_compare(), Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 14/23] qemu-img: Speed up compare on pre-allocated larger file, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 15/23] qemu-img: Add find_nonzero(), Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 16/23] qemu-img: Drop redundant error message in compare, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 17/23] qemu-img: Change check_empty_sectors() to byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 18/23] qemu-img: Change compare_sectors() to be byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 19/23] qemu-img: Change img_rebase() to be byte-based, Eric Blake, 2017/07/13
- [Qemu-block] [PATCH v3 20/23] qemu-img: Change img_compare() to be byte-based, Eric Blake, 2017/07/13