[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH RFC v3 5/8] block: add BlockDevOpti
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI |
Date: |
Wed, 28 Jun 2017 18:18:25 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 28.06.2017 um 18:02 hat Eric Blake geschrieben:
> On 06/28/2017 10:50 AM, Kevin Wolf wrote:
> > Am 23.06.2017 um 14:46 hat Manos Pitsidianakis geschrieben:
> >> This is needed to configure throttle filter driver nodes with QAPI.
> >>
> >> Signed-off-by: Manos Pitsidianakis <address@hidden>
> >> ---
> >> qapi/block-core.json | 19 ++++++++++++++++++-
> >> 1 file changed, 18 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/qapi/block-core.json b/qapi/block-core.json
> >> index f85c2235c7..1d4afafe8c 100644
> >> --- a/qapi/block-core.json
> >> +++ b/qapi/block-core.json
> >> @@ -2119,7 +2119,7 @@
> >> 'host_device', 'http', 'https', 'iscsi', 'luks', 'nbd', 'nfs',
> >> 'null-aio', 'null-co', 'parallels', 'qcow', 'qcow2', 'qed',
> >> 'quorum', 'raw', 'rbd', 'replication', 'sheepdog', 'ssh',
> >> - 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat', 'vxhs' ] }
> >> + 'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat', 'vxhs' ] }
> >>
> >> ##
> >> # @BlockdevOptionsFile:
> >> @@ -2984,6 +2984,7 @@
> >> 'replication':'BlockdevOptionsReplication',
> >> 'sheepdog': 'BlockdevOptionsSheepdog',
> >> 'ssh': 'BlockdevOptionsSsh',
> >> + 'throttle': 'BlockdevOptionsThrottle',
> >> 'vdi': 'BlockdevOptionsGenericFormat',
> >> 'vhdx': 'BlockdevOptionsGenericFormat',
> >> 'vmdk': 'BlockdevOptionsGenericCOWFormat',
> >> @@ -3723,3 +3724,19 @@
> >> 'data' : { 'parent': 'str',
> >> '*child': 'str',
> >> '*node': 'str' } }
> >> +
> >> +##
> >> +# @BlockdevOptionsThrottle:
> >> +#
> >> +# Driver specific block device options for Throttle
> >> +#
> >> +# @throttling-group: the name of the throttling group to use
> >> +#
> >> +# @options: BlockIOThrottle options
> >
> > Missing #optional marker.
>
> The marker is now auto-generated based solely on the '*options' below,
> so we don't need a redundant thing here.
Oh nice, progress!
Kevin
pgpPv_wPw7NeH.pgp
Description: PGP signature
- Re: [Qemu-block] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM, (continued)
[Qemu-block] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI, Manos Pitsidianakis, 2017/06/23
[Qemu-block] [PATCH RFC v3 6/8] block: add options parameter to bdrv_new_open_driver(), Manos Pitsidianakis, 2017/06/23
[Qemu-block] [PATCH RFC v3 7/8] block: remove legacy I/O throttling, Manos Pitsidianakis, 2017/06/23
[Qemu-block] [PATCH RFC v3 8/8] block: add throttle block filter driver interface tests, Manos Pitsidianakis, 2017/06/23