qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] util: remove the obsolete non-blocking connect


From: Mao Zhongyi
Subject: Re: [Qemu-block] [PATCH] util: remove the obsolete non-blocking connect
Date: Thu, 15 Jun 2017 15:56:27 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0



On 06/15/2017 03:34 PM, Juan Quintela wrote:
Mao Zhongyi <address@hidden> wrote:
From: Cao jin <address@hidden>

The non-blocking connect mechanism is obsolete, and it doesn't
work well in inet connection, because it will call getaddrinfo
first and getaddrinfo will blocks on DNS lookups. Since commit
e65c67e4 & d984464e, the non-blocking connect of migration goes
through QIOChannel in a different manner(using a thread), and
nobody use this old non-blocking connect anymore.

Any newly written code which needs a non-blocking connect should
use the QIOChannel code, so we can drop NonBlockingConnectHandler


Reviewed-by: Juan Quintela <address@hidden>


...

 int inet_connect_saddr(InetSocketAddress *saddr,
-                       NonBlockingConnectHandler *callback, void *opaque,
                        Error **errp);

In case you have to respin it.

Now you can write the prototype in a single line, no?
Same for the rest of appearances.


OK, I see, will fix it in the next version.

Thanks
Mao





reply via email to

[Prev in Thread] Current Thread [Next in Thread]