Re: [Qemu-block] null-co undefined read behavior

[Max Reitz]

On 2017-06-13 12:42, Stefan Hajnoczi wrote:
> On Mon, Jun 12, 2017 at 05:20:55PM -0400, John Snow wrote:
>> (3) Edit any tests to always use the zero option when using the null
>> driver, and then periodically keep updating this option in a losing
>> battle over time.
> 
> read-zeroes=on would have been a nicer default value because changing it
> could cause problems.

But it was introduced only after null-co was present already. So having
introduced it as being on by default would have caused the same problems
as changing it would now -- and I don't think that would be very large
issues.

In any case, depending on how long 3.0 is off, we can always switch it
there...

Max

> We can do the following:
> 
> Print a warning when null-* is instantiated with read-zeroes=off.  This
> will alert humans and it will make the missing option obvious in test
> output (hopefully we don't filter the warning out!).

signature.asc
Description: OpenPGP digital signature